gokceni commented on a change in pull request #704: PHOENIX-5713: Incorrectly
handled view and view indexes with/without …
URL: https://github.com/apache/phoenix/pull/704#discussion_r374812003
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/index/IndexScrutinyMapperTest.java
##########
@@ -0,0 +1,117 @@
+package org.apache.phoenix.index;
+
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.phoenix.mapreduce.index.IndexScrutinyMapper;
+import org.apache.phoenix.query.BaseConnectionlessQueryTest;
+import org.apache.phoenix.schema.PName;
+import org.apache.phoenix.schema.PNameFactory;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.PTableType;
+import org.apache.phoenix.util.MetaDataUtil;
+import org.apache.phoenix.util.SchemaUtil;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.mockito.Mockito;
+
+import java.util.Arrays;
+import java.util.Collection;
+
+@RunWith(Parameterized.class)
+public class IndexScrutinyMapperTest extends BaseConnectionlessQueryTest {
+ String schema, tableName, viewName, viewIndex, indexName;
+ boolean isNamespaceEnabled;
+ PTable inputTable;
+
+ @Before
+ public void setup() {
+ schema = "S_"+generateUniqueName();
+ tableName = "T_"+generateUniqueName();
+ viewName = "V_"+generateUniqueName();
+ viewIndex = "VI_"+generateUniqueName();
+ indexName = "I_"+generateUniqueName();
+ inputTable = Mockito.mock(PTable.class);
+
+ }
+
+ @Parameterized.Parameters(name
="IndexUpgradeToolTest_isNamespaceEnabled={0}")
+ public static synchronized Collection<Boolean> data() {
+ return Arrays.asList( false, true);
+ }
+
+ public IndexScrutinyMapperTest(boolean isNamespaceEnabled) {
+ this.isNamespaceEnabled = isNamespaceEnabled;
+ }
+ @Test
+ public void testGetSourceTableName_table() {
+ String fullTableName = SchemaUtil.getQualifiedTableName(schema,
tableName);
+ PName sourcePhysicalName =
SchemaUtil.getPhysicalHBaseTableName(schema, tableName,
+ isNamespaceEnabled);
+ String expectedName =
SchemaUtil.getPhysicalTableName(Bytes.toBytes(fullTableName),
+ isNamespaceEnabled).toString();
+ //setup
+ Mockito.when(inputTable.getType()).thenReturn(PTableType.TABLE);
+
Mockito.when(inputTable.getPhysicalName()).thenReturn(sourcePhysicalName);
+
Mockito.when(inputTable.getTableName()).thenReturn(PNameFactory.newName(tableName));
+
Mockito.when(inputTable.getSchemaName()).thenReturn(PNameFactory.newName(schema));
+ //test
+ String output = IndexScrutinyMapper.getSourceTableName(inputTable,
isNamespaceEnabled);
+ //assert
+ Assert.assertEquals(expectedName, output);
+ }
+
+ @Test
+ public void testGetSourceTableName_view() {
+ String fullTableName = SchemaUtil.getQualifiedTableName(schema,
tableName);
+ PName sourcePhysicalName =
SchemaUtil.getPhysicalHBaseTableName(schema, tableName,
+ isNamespaceEnabled);
+ String expectedName =
SchemaUtil.getPhysicalTableName(Bytes.toBytes(fullTableName),
+ isNamespaceEnabled).toString();
+ //setup
+ Mockito.when(inputTable.getType()).thenReturn(PTableType.VIEW);
+
Mockito.when(inputTable.getPhysicalName()).thenReturn(sourcePhysicalName);
+ //test
+ String output = IndexScrutinyMapper.getSourceTableName(inputTable,
isNamespaceEnabled);
+ //assert
+ Assert.assertEquals(expectedName, output);
+ }
+
+ @Test
+ public void testGetSourceTableName_index() {
+ String fullTableName = SchemaUtil.getQualifiedTableName(schema,
indexName);
+ PName sourcePhysicalName =
SchemaUtil.getPhysicalHBaseTableName(schema, indexName,
+ isNamespaceEnabled);
+ String expectedName =
SchemaUtil.getPhysicalTableName(Bytes.toBytes(fullTableName),
+ isNamespaceEnabled).toString();
+
+ //setup
+ Mockito.when(inputTable.getType()).thenReturn(PTableType.INDEX);
+
Mockito.when(inputTable.getPhysicalName()).thenReturn(sourcePhysicalName);
+
Mockito.when(inputTable.getTableName()).thenReturn(PNameFactory.newName(indexName));
+
Mockito.when(inputTable.getSchemaName()).thenReturn(PNameFactory.newName(schema));
+
+ //test
+ String output = IndexScrutinyMapper.getSourceTableName(inputTable,
isNamespaceEnabled);
+ //assert
+ Assert.assertEquals(expectedName, output);
+ }
+
+ @Test
+ public void testGetSourceTableName_viewIndex() {
+ PName physicalTableName = SchemaUtil.getPhysicalHBaseTableName(schema,
tableName,
Review comment:
I would suggest creating actual views, indexes, etc rather than mocking so
that we are sure there is no test bug and the name convention is indeed as we
expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
