[
https://issues.apache.org/jira/browse/PHOENIX-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032800#comment-17032800
]
Hadoop QA commented on PHOENIX-5633:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12992941/PHOENIX-5633.master.v4.patch
against master branch at commit 1ae0ba644f8aa188adfd93af96ae3df74ec43f3d.
ATTACHMENT ID: 12992941
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "Scan on table " +
context.getCurrentTable().getTable().getName() + " ready for iteration: " +
scan, connection));
+ "Iterator for table " +
context.getCurrentTable().getTable().getName() + " ready: " + iterator,
connection));
+ ScanUtil.getCustomAnnotations(scan)) + "on table " +
context.getCurrentTable().getTable().getName());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexMetadataIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3406//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3406//console
This message is automatically generated.
> Add table name info to scan logging
> -----------------------------------
>
> Key: PHOENIX-5633
> URL: https://issues.apache.org/jira/browse/PHOENIX-5633
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Christine Feng
> Priority: Major
> Labels: beginner, newbie
> Fix For: 4.15.1
>
> Attachments: PHOENIX-5633.master.v1.patch,
> PHOENIX-5633.master.v2.patch, PHOENIX-5633.master.v3.patch,
> PHOENIX-5633.master.v4.patch
>
>
> We log the scans at the debug level at various places such as inside
> _BaseQueryPlan_, _BaseResultIterators_, _Parallelterators_, etc. To help with
> debugging, we should also print the table name that the scan will be
> scanning. An example of a log line for a scan currently, is:
> {code:java}
> 19/12/16 22:10:38 DEBUG execute.BaseQueryPlan: Scan ready for iteration:
> {"loadColumnFamiliesOnDemand":true,"startRow":"","stopRow":"","batch":-1,"cacheBlocks":true,"totalColumns":1,"maxResultSize":-1,"families":{"0":["ALL"]},"caching":2147483647,"maxVersions":1,"timeRange":[0,9223372036854775807]}
> {code}
> OR
> {code:java}
> 19/12/16 22:10:38 DEBUG iterate.BaseResultIterators: Getting iterators for
> ResultIterators
> [name=PARALLEL,id=1de62127-8ce9-b8d0-4881-6eaec8835ea5,scans=[[{"loadColumnFamiliesOnDemand":true,"startRow":"","stopRow":"","batch":-1,"cacheBlocks":true,"totalColumns":1,"maxResultSize":-1,"families":{"0":["ALL"]},"caching":2147483647,"maxVersions":1,"timeRange":[0,9223372036854775807]}]]]
> 19/12/16 22:10:38 DEBUG iterate.ParallelIterators: Id:
> 1de62127-8ce9-b8d0-4881-6eaec8835ea5, Time: 0ms, Scan:
> {"loadColumnFamiliesOnDemand":true,"startRow":"","stopRow":"","batch":-1,"cacheBlocks":true,"totalColumns":1,"maxResultSize":-1,"families":{"0":["ALL"]},"caching":2147483647,"maxVersions":1,"timeRange":[0,9223372036854775807]}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
