[
https://issues.apache.org/jira/browse/PHOENIX-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035410#comment-17035410
]
Hadoop QA commented on PHOENIX-5724:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12993252/PHOENIX-5724.patch
against master branch at commit 14eacf4d6a0f129d014c208b591c654160cee94a.
ATTACHMENT ID: 12993252
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ this.execPermissionsCheckEnabled =
conf.getBoolean(AccessControlConstants.EXEC_PERMISSION_CHECKS_KEY,
+ requireAccess("Create" + tableType, parentPhysicalTableName,
Action.READ, Action.EXEC);
+ List<Action> actions = Arrays.asList(Action.READ,
Action.WRITE, Action.CREATE, Action.ADMIN);
+ requireAccess("Alter "+tableType, parentPhysicalTableName,
Action.READ, Action.EXEC);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3430//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3430//console
This message is automatically generated.
> Use exec permission in Phoenix ACLs only when execute check enabled
> -------------------------------------------------------------------
>
> Key: PHOENIX-5724
> URL: https://issues.apache.org/jira/browse/PHOENIX-5724
> Project: Phoenix
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5724.patch
>
>
> Currently in PhoenixAccessController we are checking for exec permissions but
> in HBase by default exec permission check is disabled and optional so better
> to use exec only the the exec check enabled otherwise Phoenix ACLs with
> Ranger also not working.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
