[
https://issues.apache.org/jira/browse/PHOENIX-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037485#comment-17037485
]
Hadoop QA commented on PHOENIX-5718:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12993543/PHOENIX-5718.4.x-HBase-1.3.v1.patch
against 4.x-HBase-1.3 branch at commit
f592bfdecbf5a50b54f71bad82f52a0504d6eaf5.
ATTACHMENT ID: 12993543
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3444//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3444//console
This message is automatically generated.
> GetTable builds a table excluding the given clientTimeStamp
> -----------------------------------------------------------
>
> Key: PHOENIX-5718
> URL: https://issues.apache.org/jira/browse/PHOENIX-5718
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.16.0
> Reporter: Sandeep Guggilam
> Assignee: Sandeep Guggilam
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5718.4.x-HBase-1.3.v1.patch,
> PHOENIX-5718.master.v1.patch
>
>
> Here is the scenario tested:
> # Brought up a server with 4.16 where new columns are added but not added as
> part of upgrade path
> # Connect with 4.14 client
> # Connect with a 4.16 client - this will throw an exception as the new
> columns added as part of 4.16 were not added as part of upgrade path
> # Now the code will force update the cache in
> PhoenixStatement#executeQuery() method
> # Now the buildTable is removing even the columns added as part of 4.15 ,
> the reason being we are passing the clientTimeStamp to build table ( say 29
> is the timestamp for column added for 4.15) but the table is scanning rows
> EXCLUDING the passed clientTimeSTamp as the Scan#setTimeRange method excludes
> the end time stamp
> The passing of clientTimeStamp to build table is in
> MetaDataEndPointImpl#doGetTable method
--
This message was sent by Atlassian Jira
(v8.3.4#803005)