[
https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039322#comment-17039322
]
Geoffrey Jacoby edited comment on PHOENIX-5728 at 2/18/20 6:21 PM:
-------------------------------------------------------------------
No concerns with the line length for the JSON files. We do need to find a way
to make the release audit green, however.
I agree with the goal of getting the ugly hard-coded explain plan assertions
out of tests, and I don't object to the idea of gold files in general, but
wouldn't it be simpler in many cases to just have an object-based explain plan
with individual fields that can be asserted against? That would be quite useful
as an end-user API as well (such as if an operator wants to check to see if a
query will do a table scan before doing so.)
My concern is that instead of brittle hard-coded tests, you wind up with
brittle JSON files. Which would be an improvement, but still not ideal.
was (Author: gjacoby):
No concerns with the line length for the JSON files. We do need to find a way
to make the release audit green, however.
I agree with the goal of getting the ugly hard-coded explain plan assertions
out of tests, and I don't object to the idea of gold files in general, but
wouldn't it be simpler in many cases to just have an object-based explain plan
with individual fields that can be asserted against? That would be quite useful
as an end-user API as well (such as if an operator wants to check to see if a
query will do a table scan before doing so.)
> Gold files for Phoenix test BaseStatsCollectorIT
> ------------------------------------------------
>
> Key: PHOENIX-5728
> URL: https://issues.apache.org/jira/browse/PHOENIX-5728
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.1.0, 4.15.1
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5728.master.000.patch,
> PHOENIX-5728.master.000.patch
>
>
> Provide golden files for QueryPlan result comparison for all abstract test
> class BaseStatsCollectorIT that includes tests of all stats collections
> including:
> * NamespaceDisabledStatsCollectorIT
> * NamespaceEnabledStatsCollectorIT
> * NonTxStatsCollectorIT
> * TxStatsCollectorIT
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
