gokceni commented on a change in pull request #711: PHOENIX-5743 Concurrent
read repairs on the same index row should be…
URL: https://github.com/apache/phoenix/pull/711#discussion_r382279649
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -247,18 +247,10 @@ private void deleteRowIfAgedEnough(byte[] indexRowKey,
List<Cell> row, long ts,
if ((EnvironmentEdgeManager.currentTimeMillis() - ts) >
ageThreshold) {
Delete del = new Delete(indexRowKey, ts);
if (specific) {
- // Get all the cells of this row
- deleteRowScan.withStartRow(indexRowKey, true);
- deleteRowScan.withStopRow(indexRowKey, true);
- deleteRowScan.setTimeRange(0, ts + 1);
- deleteRowScanner = region.getScanner(deleteRowScan);
- row.clear();
- deleteRowScanner.next(row);
- deleteRowScanner.close();
- // We are deleting a specific version of a row so the
flowing loop is for that
- for (Cell cell : row) {
- del.addColumn(CellUtil.cloneFamily(cell),
CellUtil.cloneQualifier(cell), cell.getTimestamp());
- }
+
del.addFamilyVersion(indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(),
ts);
+ }
+ else {
Review comment:
nit: else should be next to } like
} else {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
