[
https://issues.apache.org/jira/browse/PHOENIX-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043214#comment-17043214
]
Hadoop QA commented on PHOENIX-5734:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12994270/PHOENIX-5734.4.x-HBase-1.3.v1.patch
against 4.x-HBase-1.3 branch at commit
dd31f74b68c4ad984dd30bc77cc335be0ad9056f.
ATTACHMENT ID: 12994270
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
props.put(QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB,
Long.toString(0));
+ props.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Integer.toString(IndexScrutinyMapperForTest.MAX_LOOKBACK));
+ dataTableFullName =
SourceTable.DATA_TABLE_SOURCE.equals(sourceTable) ? qSourceTable : qTargetTable;
+ targetPTable = SourceTable.DATA_TABLE_SOURCE.equals(sourceTable) ?
pindexTable : pdataTable;
+ ConnectionQueryServices cqsi =
connection.unwrap(PhoenixConnection.class).getQueryServices();
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexScrutinyToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SplitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexScrutinyToolForTenantIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3480//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3480//console
This message is automatically generated.
> IndexScrutinyTool should not report rows beyond maxLookBack age
> ---------------------------------------------------------------
>
> Key: PHOENIX-5734
> URL: https://issues.apache.org/jira/browse/PHOENIX-5734
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5734.4.x-HBase-1.3.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Index Scrutiny tool should not report row mismatch if the row gets rewritten
> during the run and the last version around is beyond max look back age which
> will then get removed by compaction.
>
> Or add another type of counters to separate invalid rows into
> BEYOND_MAX_LOOKBACK or similar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
