ChinmaySKulkarni commented on a change in pull request #710: PHOENIX-5673 : The
mutation state is silently getting cleared on the …
URL: https://github.com/apache/phoenix/pull/710#discussion_r383444872
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/execute/MutationStateTest.java
##########
@@ -175,4 +185,43 @@ public void testGetMutationBatchList() {
}
+ @Test(expected = SQLException.class)
+ public void testPendingMutationsOnDDL() throws Exception {
+ Connection conn = null;
+ PhoenixConnection spy = null;
+ try {
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+
props.setProperty(QueryServices.PENDING_MUTATIONS_DDL_THROW_ATTRIB, "true");
+ conn = DriverManager.getConnection(getUrl(), props);
Review comment:
Surround connection with try-with-resources for auto-closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
