ChinmaySKulkarni commented on a change in pull request #696: PHOENIX-5607 Client-server backward compatibility tests URL: https://github.com/apache/phoenix/pull/696#discussion_r383565286
########## File path: phoenix-core/src/it/resources/sql_files/add_delete.sql ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +CREATE TABLE my_schema.my_table_delete + (id VARCHAR not null primary key, name VARCHAR) SALT_BUCKETS=4; +UPSERT INTO my_schema.my_table_delete values ('a','a_name'); +CREATE INDEX my_table_idx_delete on my_schema.my_table_delete (name); +DROP INDEX my_table_idx_delete ON my_schema.my_table_delete; +DELETE FROM my_schema.my_table_delete; +DROP TABLE my_schema.my_table_delete; + +UPSERT INTO my_schema.my_table values ('y','y_name'); +UPSERT INTO my_schema.my_table_immutable values ('y','y_name'); Review comment: We should probably keep the newlines at the end of each file to prevent possible compiler warnings etc. see: https://unix.stackexchange.com/a/18789/397112 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
