[ 
https://issues.apache.org/jira/browse/PHOENIX-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044178#comment-17044178
 ] 

Hadoop QA commented on PHOENIX-5709:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12994480/PHOENIX-5709.4.x-HBase-1.3.010.patch
  against 4.x-HBase-1.3 branch at commit 
e1aee8e5d3fe335450db583f01cf91af1e6c5c7e.
  ATTACHMENT ID: 12994480

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to 
fail .

    Compilation errors resume:
    [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean (default-clean) on 
project phoenix-core: Failed to clean project: Failed to delete 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/target
 -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :phoenix-core
    

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3483//console

This message is automatically generated.

> Simplify index update generation code for consistent global indexes
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-5709
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5709
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.14.3
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 5.0.0, 4.14.3
>
>         Attachments: PHOENIX-5709.4.x-HBase-1.3.001.patch, 
> PHOENIX-5709.4.x-HBase-1.3.002.patch, PHOENIX-5709.4.x-HBase-1.3.003.patch, 
> PHOENIX-5709.4.x-HBase-1.3.004.patch, PHOENIX-5709.4.x-HBase-1.3.005.patch, 
> PHOENIX-5709.4.x-HBase-1.3.006.patch, PHOENIX-5709.4.x-HBase-1.3.007.patch, 
> PHOENIX-5709.4.x-HBase-1.3.008.patch, PHOENIX-5709.4.x-HBase-1.3.009.patch, 
> PHOENIX-5709.4.x-HBase-1.3.010.patch, PHOENIX-5709.master.001.patch, 
> PHOENIX-5709.master.002.patch, PHOENIX-5709.master.003.patch, 
> PHOENIX-5709.master.004.patch, PHOENIX-5709.master.005.patch, 
> PHOENIX-5709.master.006.patch, PHOENIX-5709.master.007.patch, 
> PHOENIX-5709.master.008.patch, PHOENIX-5709.master.009.patch, 
> PHOENIX-5709.master.010.patch, PHOENIX-5709.master.011.patch, 
> PHOENIX-5709.master.012.patch, PHOENIX-5709.master.013.patch, 
> PHOENIX-5709.master.014.patch
>
>          Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> The implementation of the new global index design by PHOENIX-5156 essentially 
> introduced two coprocessors, IndexRegionObserver and GlobalIndexChecker. 
> IndexRegionObserver is the counterpart of the existing Indexer coprocessor 
> that the previous global indexing feature uses. It implements the indexing 
> write path. GlobalIndexChecker implements the read verification and read 
> repair that happens on the read path. One of the main objectives of the 
> design behind new global indexing was to leverage as much existing indexing 
> code as possible. This objective has been achieved greatly as the entire 
> index table update generation code implemented by various classes (including 
> PhoenixIndexBuilder, CachedLocalTable, NonTxIndexBuilder, IndexUpdateManager, 
>  LocalTableState, ScannerBuilder, IndexMemStore and PhoenixIndexCodec) is 
> leveraged as it is mainly. This objective has served us well to deliver the 
> new indexing feature quickly. The leveraged code is very complex, over 
> engineered, and inefficient, and is not bug free. It is very hard to 
> maintain. It is time to replace the complex set of classes with something 
> drastically simpler and more efficient for the new design.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to