[
https://issues.apache.org/jira/browse/PHOENIX-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044477#comment-17044477
]
Richard Antal commented on PHOENIX-4679:
----------------------------------------
It is already done.
[https://github.com/apache/phoenix/commit/87cc9b45f959664b0069132ca00878ab9c60ab88]
> Exit build-proto.sh if not using protoc v2.5.0
> ----------------------------------------------
>
> Key: PHOENIX-4679
> URL: https://issues.apache.org/jira/browse/PHOENIX-4679
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Marcell Ortutay
> Priority: Minor
>
> If you use a version of protoc later than v2.5.0 to regenerate protobufs,
> you'll get a diff from the current protobuf generated code, even if you made
> no changes to the .proto files. I assume this is undesirable, so it would be
> nice if the build-proto.sh script warned people about this. The following
> check would do this:
> {code:java}
> if [[ `protoc --version` != *"2.5.0"* ]]; then
> echo "Must use protoc version 2.5.0"
> exit 1
> fi
> {code}
> If this seems useful I can submit a PR to implement this
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
