[
https://issues.apache.org/jira/browse/PHOENIX-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045215#comment-17045215
]
Hadoop QA commented on PHOENIX-5496:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12994618/PHOENIX-5496.4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
eccc370b6d7d4b1e779228db8804343b9e41930c.
ATTACHMENT ID: 12994618
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail .
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:[3054,57]
incompatible types: com.google.common.collect.ImmutableList<java.lang.Object>
cannot be converted to java.util.List<org.apache.phoenix.schema.PColumn>
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile)
on project phoenix-core: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:[3054,57]
incompatible types: com.google.common.collect.ImmutableList<java.lang.Object>
cannot be converted to java.util.List<org.apache.phoenix.schema.PColumn>
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :phoenix-core
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3490//console
This message is automatically generated.
> Ensure that we handle all server-side mutation codes on the client
> ------------------------------------------------------------------
>
> Key: PHOENIX-5496
> URL: https://issues.apache.org/jira/browse/PHOENIX-5496
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Chinmay Kulkarni
> Assignee: Neha Gupta
> Priority: Major
> Fix For: 4.15.1, 5.1.1
>
> Attachments: PHOENIX-5496.4.x-HBase-1.3.patch,
> PHOENIX-5496.master.patch, PHOENIX-5496.patch, PHOENIX-5496.v1.patch,
> PHOENIX-5496.v2.patch, PHOENIX-5496.v3.patch
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> There are many instances throughout wherein we set a certain error mutation
> code in the RPC callback, however we do not handle these mutation codes on
> the client.
> For example:
> If the metadata rows for a tableKey are no longer in that SYSCAT region,
> checkTableKeyInRegion() fails, the metadata for this table is not written to
> SYSCAT and [the TABLE_NOT_IN_REGION mutation code is
> set|https://github.com/apache/phoenix/blob/11997d48d1957cf613526f01c5ccbe2812cf095d/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1785-L1790].
> This is handled for 1 retry inside
> [CQSI.metaDataCoprocessorExec|https://github.com/apache/phoenix/blob/11997d48d1957cf613526f01c5ccbe2812cf095d/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L1568-L1570],
> but if this happens again, it is returned back to the client where it goes
> to the default case and succeeds.
> Apart from the fact that partial metadata updates are possible leading to
> orphan metadata rows in system tables, this also wrongly returns success for
> clients even though there is no record of that table/view being created
> inside Phoenix's system tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
