dbwong commented on a change in pull request #708: PHOENIX-5698 Phoenix Query
with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r384412396
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/expression/InListExpressionTest.java
##########
@@ -19,13 +19,19 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.when;
import com.google.common.collect.Lists;
import java.util.ArrayList;
import java.util.List;
+
import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.phoenix.compile.WhereOptimizer;
import org.apache.phoenix.hbase.index.util.ImmutableBytesPtr;
+import org.apache.phoenix.schema.PColumn;
+import org.apache.phoenix.schema.PTable;
import org.junit.Test;
+import org.mockito.Mockito;
public class InListExpressionTest {
Review comment:
The tests for this should not live in this class. This class should be only
for InListExpression changes, of which you have none.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
