[
https://issues.apache.org/jira/browse/PHOENIX-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051541#comment-17051541
]
Hadoop QA commented on PHOENIX-5673:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12995646/PHOENIX-5673.4.x-HBase-1.3.v2.patch
against 4.x-HBase-1.3 branch at commit
3013c3e954ebdbec7274cb950e3583bc08975135.
ATTACHMENT ID: 12995646
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "Cannot perform DDL with pending mutations. Commit or rollback
mutations before performing DDL");
+ "There are Uncommitted mutations, which will be dropped on
the execution of this DDL statement.");
+ public static final String PENDING_MUTATIONS_DDL_THROW_ATTRIB =
"phoenix.pending.mutations.before.ddl.throw";
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterSessionIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3537//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3537//console
This message is automatically generated.
> The mutation state is silently getting cleared on the execution of any DDL
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5673
> URL: https://issues.apache.org/jira/browse/PHOENIX-5673
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Sandeep Guggilam
> Assignee: Siddhi Mehta
> Priority: Critical
> Labels: beginner, newbie
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5673.4.x-HBase-1.3.v1.patch,
> PHOENIX-5673.4.x-HBase-1.3.v2.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When we execute any DDL statement, the mutations state is rolled back
> silently without informing the user. It should probably throw an exception
> saying that the mutation state is not empty when executing any DDL. See the
> below example:
>
> Steps to reproduce:
> create table t1 (pk varchar not null primary key, mycol varchar)
> upsert into t1 (pk, mycol) values ('x','x');
> create table t2 (pk varchar not null primary key, mycol varchar)
> When we try to execute the above statements and do a conn.commit() at the
> end, it would silently rollback the upsert statement when we execute the
> second create statement and you wouldn't see the ('x', 'x') values in the
> first table. Instead it should probably throw an exception saying that the
> mutation state is not empty
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
