[
https://issues.apache.org/jira/browse/PHOENIX-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055512#comment-17055512
]
Hadoop QA commented on PHOENIX-5065:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12996226/PHOENIX-5065.master.v5.patch
against master branch at commit 6a2ad3ed4517ff23e0e5dff3f364c1c0673b8efc.
ATTACHMENT ID: 12996226
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinNoIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectAutoCommitIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3558//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3558//console
This message is automatically generated.
> Inconsistent treatment of NULL and empty string
> -----------------------------------------------
>
> Key: PHOENIX-5065
> URL: https://issues.apache.org/jira/browse/PHOENIX-5065
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1
> Reporter: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5065.master.v1.patch,
> PHOENIX-5065.master.v2.patch, PHOENIX-5065.master.v3.patch,
> PHOENIX-5065.master.v4.patch, PHOENIX-5065.master.v5.patch
>
>
> Phoenix doesn't handle NULLs consistently with other SQL dialects, and it
> doesn't handle them consistently internally either.
> In PHOENIX-2422, [~jamestaylor] mentioned that Phoenix's intended behavior is
> for empty string and NULL to be equivalent. That's inconsistent with other
> SQL dialects (in which NULL is never equal to anything, including itself),
> but if that's our documented behavior, then that's fine unless PHOENIX-2422
> to change it is ever worked.
> But consider the following queries:
> {code:java}
> SELECT COUNT(*) FROM SYSTEM.CATALOG WHERE TENANT_ID = '';
> -- Returns 0 rows
> SELECT COUNT(*) FROM SYSTEM.CATALOG WHERE TENANT_ID IS NULL;
> -- Returns some number of rows. Call it N
> SELECT COUNT(*) FROM SYSTEM.CATALOG WHERE TENANT_ID IN ('');
> -- Returns 0 rows
> SELECT COUNT(*) FROM SYSTEM.CATALOG WHERE TENANT_ID IN ('', 'FOO');
> -- Returns N rows. Note that FOO does not exist, and is just a nonsense string
> SELECT COUNT(*) FROM SYSTEM.CATALOG WHERE TENANT_ID = '' OR TENANT_ID = 'FOO'
> --Returns 0 rows, but slowly
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
