dbwong commented on issue #729: PHOENIX-5766 PhoenixMetricsIT failure in 4.x for HBase 1.3 URL: https://github.com/apache/phoenix/pull/729#issuecomment-597293750 Okay, I think I understand whats going on more here. I do like the branch merging work but I don't really think this is the right approach in our tests. Either we should break out the tests and exclude them in your newly created profiles. Or have a hbase-compat interface that we can query about functionality. As HBase/Phoenix continue to evolve something like that would likely be useful for maintaining the versions/changes. Essentially a class that has isHbaseMetricsApiAdapterAvailable and then underneath you could have this class loader approach. The tests, or other classes could then call into this interface for determining code flow. Thoughts @stoty ? Maybe you already opened/have a JIRA on this I haven't been keeping up in detail.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
