[ 
https://issues.apache.org/jira/browse/PHOENIX-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056431#comment-17056431
 ] 

Hadoop QA commented on PHOENIX-5760:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12996322/PHOENIX-5760.patch
  against master branch at commit 8a048e96d9e44fdb86f8fee8eecfcadb9970858b.
  ATTACHMENT ID: 12996322

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        return new DataValue(columnRule.getType(), 
String.valueOf((counter.getAndIncrement() % (maxValue - minValue + 1)) + 
minValue));
+            if (!DataTypeMapping.INTEGER.equals(column.getType()) && sequence 
== DataSequence.SEQUENTIAL) {
+            if (DataTypeMapping.INTEGER.equals(column.getType()) && sequence 
== DataSequence.SEQUENTIAL) {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.AlterIndexIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3563//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3563//console

This message is automatically generated.

> Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row 
> distribution
> ------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5760
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5760
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Daniel Wong
>            Assignee: Daniel Wong
>            Priority: Minor
>         Attachments: PHOENIX-5760.patch
>
>
> In order to run pherf test closer to how users do QueryMore we want to extend 
> the Sequential datatype to integer fields with guaranteed values. 
> In general we want to be able to generate data for a column from 1..N in 
> pherf contiguously.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to