kadirozde commented on a change in pull request #728: Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r391282828
########## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebuildTest.java ########## @@ -0,0 +1,727 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.index; + +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.CellUtil; +import org.apache.hadoop.hbase.KeyValue; +import org.apache.hadoop.hbase.client.Delete; +import org.apache.hadoop.hbase.client.Mutation; +import org.apache.hadoop.hbase.client.Put; +import org.apache.hadoop.hbase.io.ImmutableBytesWritable; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.Pair; +import org.apache.phoenix.coprocessor.IndexRebuildRegionScanner; +import org.apache.phoenix.end2end.index.IndexTestUtil; +import org.apache.phoenix.hbase.index.IndexRegionObserver; +import org.apache.phoenix.hbase.index.util.GenericKeyValueBuilder; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.query.BaseConnectionlessQueryTest; +import org.apache.phoenix.query.QueryConstants; +import org.apache.phoenix.schema.PName; +import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.PTableKey; +import org.apache.phoenix.util.SchemaUtil; +import org.junit.Assert; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; + +import static org.junit.Assert.assertEquals; + +public class PrepareIndexMutationsForRebuildTest extends BaseConnectionlessQueryTest { + private static String ROW_KEY = "k1"; + private static String TABLE_NAME = "dataTable"; + private static String INDEX_NAME = "idx"; + private static final Logger LOGGER = LoggerFactory.getLogger(PrepareIndexMutationsForRebuildTest.class); + + class SetupInfo{ + public IndexMaintainer indexMaintainer; + public PTable pDataTable; + } + + private SetupInfo setupIndexMaintainer(String tableName, + String indexName, + String columns, + String indexColumns, + String pk, + String includeColumns) throws Exception{ + Connection conn = DriverManager.getConnection(getUrl()); + + String fullTableName = SchemaUtil.getTableName(SchemaUtil.normalizeIdentifier(""),SchemaUtil.normalizeIdentifier(tableName)); + String fullIndexName = SchemaUtil.getTableName(SchemaUtil.normalizeIdentifier(""),SchemaUtil.normalizeIdentifier(indexName)); + + String str1 = String.format("CREATE TABLE %1$s (%2$s CONSTRAINT pk PRIMARY KEY (%3$s)) COLUMN_ENCODED_BYTES=0", + fullTableName, + columns, + pk); + conn.createStatement().execute(str1); + + String str2 = String.format("CREATE INDEX %1$s ON %2$s (%3$s)", + fullIndexName, + fullTableName, + indexColumns); + if (!includeColumns.isEmpty()) + str2 += " INCLUDE (" + includeColumns + ")"; + conn.createStatement().execute(str2); + + PhoenixConnection pconn = conn.unwrap(PhoenixConnection.class); + PTable pDataTable = pconn.getTable(new PTableKey(pconn.getTenantId(), fullTableName)); + ImmutableBytesWritable ptr = new ImmutableBytesWritable(); + pDataTable.getIndexMaintainers(ptr, pconn); + List<IndexMaintainer> indexMaintainers = IndexMaintainer.deserialize(ptr, GenericKeyValueBuilder.INSTANCE, true); + + SetupInfo info = new SetupInfo(); + info.indexMaintainer = indexMaintainers.get(0); + info.pDataTable = pDataTable; + return info; + } + + @Test + public void testSinglePutOnIndexColumn() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR, C2 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + null); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v1"))); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + Put idxPut1 = new Put(com.google.common.primitives.Bytes.toArray(idxKey)); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + + assertEqualMutationList(Arrays.asList((Mutation)idxPut1), actualIndexMutations); + } + + @Test + public void testSinglePutOnNonIndexColumn() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR, C2 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + null); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + Put idxPut1 = new Put(com.google.common.primitives.Bytes.toArray(idxKey)); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + + assertEqualMutationList(Arrays.asList((Mutation)idxPut1), actualIndexMutations); + } + + @Test + public void testDelOnIndexColumn() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR, C2 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + + Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY)); + addCellToDelMutation(dataDel, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 2, + KeyValue.Type.DeleteColumn); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + dataDel); + + List<Mutation> expectedIndexMutation = new ArrayList<>(); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v1"))); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes = com.google.common.primitives.Bytes.toArray(idxKey); + + Put idxPut1 = new Put(idxKeyBytes); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + expectedIndexMutation.add(idxPut1); + + List<Byte> idxKey2 = new ArrayList<>(); + idxKey2.add(QueryConstants.SEPARATOR_BYTE); + idxKey2.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + Put idxPut2 = new Put(com.google.common.primitives.Bytes.toArray(idxKey2)); + addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2); + expectedIndexMutation.add(idxPut2); + + Delete idxDel = new Delete(idxKeyBytes); + addCellToDelMutation(idxDel, + QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, + null, + 2, + KeyValue.Type.DeleteFamily); + expectedIndexMutation.add(idxDel); + + assertEqualMutationList(expectedIndexMutation, actualIndexMutations); + } + + @Test + public void testDelOnNonIndexColumn() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR, C2 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + + Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY)); + addCellToDelMutation(dataDel, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 2, + KeyValue.Type.DeleteColumn); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + dataDel); + + List<Mutation> expectedIndexMutations = new ArrayList<>(); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v1"))); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes = com.google.common.primitives.Bytes.toArray(idxKey); + + Put idxPut1 = new Put(idxKeyBytes); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + expectedIndexMutations.add(idxPut1); + + Put idxPut2 = new Put(idxKeyBytes); + addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2); + expectedIndexMutations.add(idxPut2); + + assertEqualMutationList(expectedIndexMutations, actualIndexMutations); + } + + @Test + public void testDeleteAllVersions() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 2, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 2); + + Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY)); + addCellToDelMutation(dataDel, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + null, + 3, + KeyValue.Type.DeleteFamily); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + dataDel); + + List<Mutation> expectedIndexMutations = new ArrayList<>(); + + List<Byte> idxKey1 = new ArrayList<>(); + idxKey1.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v1"))); + idxKey1.add(QueryConstants.SEPARATOR_BYTE); + idxKey1.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes1 = com.google.common.primitives.Bytes.toArray(idxKey1); + + List<Byte> idxKey2 = new ArrayList<>(); + idxKey2.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v2"))); + idxKey2.add(QueryConstants.SEPARATOR_BYTE); + idxKey2.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes2 = com.google.common.primitives.Bytes.toArray(idxKey2); + + Put idxPut1 = new Put(idxKeyBytes1); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + expectedIndexMutations.add(idxPut1); + + Put idxPut2 = new Put(idxKeyBytes2); + addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2); + expectedIndexMutations.add(idxPut2); + + Delete idxDel1 = new Delete(idxKeyBytes1); + addCellToDelMutation(idxDel1, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + null, + 2, + KeyValue.Type.DeleteFamily); + expectedIndexMutations.add(idxDel1); + + Delete idxDel2 = new Delete(idxKeyBytes2); + addCellToDelMutation(idxDel2, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + null, + 3, + KeyValue.Type.DeleteFamily); + expectedIndexMutations.add(idxDel2); + + assertEqualMutationList(expectedIndexMutations, actualIndexMutations); + } + + @Test + public void testPutDeleteOnSameTimeStamp() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable,1); + + Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY)); + addCellToDelMutation(dataDel, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + KeyValue.Type.DeleteColumn); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + dataDel); + + List<Mutation> expectedIndexMutations = new ArrayList<>(); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes = com.google.common.primitives.Bytes.toArray(idxKey); + Put idxPut1 = new Put(idxKeyBytes); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + expectedIndexMutations.add(idxPut1); + + assertEqualMutationList(Arrays.asList((Mutation)idxPut1), actualIndexMutations); + } + + @Test + public void testCoveredIndexColumns() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR, C2 VARCHAR", + "C1", + "ROW_KEY", + "C2"); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + + Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY)); + addCellToDelMutation(dataDel, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C1"), + 2, + KeyValue.Type.DeleteColumn); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + dataDel); + + List<Mutation> expectedIndexMutations = new ArrayList<>(); + List<Byte> idxKey = new ArrayList<>(); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v1"))); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes = com.google.common.primitives.Bytes.toArray(idxKey); + + Put idxPut1 = new Put(idxKeyBytes); + addCellToPutMutation(idxPut1, + QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, + Bytes.toBytes("0:C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + expectedIndexMutations.add(idxPut1); + + List<Byte> idxKey2 = new ArrayList<>(); + idxKey2.add(QueryConstants.SEPARATOR_BYTE); + idxKey2.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes2 = com.google.common.primitives.Bytes.toArray(idxKey2); + Put idxPut2 = new Put(idxKeyBytes2); + addCellToPutMutation(idxPut2, + QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, + Bytes.toBytes("0:C2"), + 2, + Bytes.toBytes("v2")); + addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2); + expectedIndexMutations.add(idxPut2); + + Delete idxDel = new Delete(idxKeyBytes); + addCellToDelMutation(idxDel, + QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, + null, + 2, + KeyValue.Type.DeleteFamily); + expectedIndexMutations.add(idxDel); + + assertEqualMutationList(expectedIndexMutations, actualIndexMutations); + } + + @Test + public void testForMultipleFamilies() throws Exception { + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, CF1.C1 VARCHAR, CF2.C2 VARCHAR", + "CF1.C1", + "ROW_KEY", + "CF2.C2"); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + Bytes.toBytes("CF1"), + Bytes.toBytes("C1"), + 1, + Bytes.toBytes("v1")); + addCellToPutMutation(dataPut, + Bytes.toBytes("CF2"), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + + Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY)); + addCellToDelMutation(dataDel, + Bytes.toBytes("CF1"), + Bytes.toBytes("C1"), + 2, + KeyValue.Type.DeleteColumn); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + dataDel); + + List<Mutation> expectedIndexMutation = new ArrayList<>(); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes("v1"))); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + byte[] idxKeyBytes = com.google.common.primitives.Bytes.toArray(idxKey); + + Put idxPut1 = new Put(idxKeyBytes); + addCellToPutMutation(idxPut1, + Bytes.toBytes("CF2"), + Bytes.toBytes("CF2:C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + expectedIndexMutation.add(idxPut1); + + List<Byte> idxKey2 = new ArrayList<>(); + idxKey2.add(QueryConstants.SEPARATOR_BYTE); + idxKey2.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + Put idxPut2 = new Put(com.google.common.primitives.Bytes.toArray(idxKey2)); + addCellToPutMutation(idxPut2, + Bytes.toBytes("CF2"), + Bytes.toBytes("CF2:C2"), + 2, + Bytes.toBytes("v2")); + addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2); + expectedIndexMutation.add(idxPut2); + + Delete idxDel = new Delete(idxKeyBytes); + addCellToDelMutation(idxDel, + Bytes.toBytes("CF2"), + null, + 2, + KeyValue.Type.DeleteFamily); + expectedIndexMutation.add(idxDel); + + assertEqualMutationList(expectedIndexMutation, actualIndexMutations); + } + + @Test + public void testSameTypeOfMutationWithDifferentTimeStamp() throws Exception{ + SetupInfo info = setupIndexMaintainer(TABLE_NAME, + INDEX_NAME, + "ROW_KEY VARCHAR, C1 VARCHAR, C2 VARCHAR", + "C1", + "ROW_KEY", + ""); + + Put dataPut = new Put(Bytes.toBytes(ROW_KEY)); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v2")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1); + addCellToPutMutation(dataPut, + info.indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(), + Bytes.toBytes("C2"), + 1, + Bytes.toBytes("v3")); + addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 2); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(info.indexMaintainer, + dataPut, + null); + + List<Byte> idxKey = new ArrayList<>(); + idxKey.add(QueryConstants.SEPARATOR_BYTE); + idxKey.addAll(com.google.common.primitives.Bytes.asList(Bytes.toBytes(ROW_KEY))); + + Put idxPut1 = new Put(com.google.common.primitives.Bytes.toArray(idxKey)); + addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1); + + Put idxPut2 = new Put(com.google.common.primitives.Bytes.toArray(idxKey)); + addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2); + + assertEqualMutationList(Arrays.asList((Mutation)idxPut1, (Mutation)idxPut2), actualIndexMutations); + } + + @Test + public void testDummy() throws Exception{ + Connection conn = DriverManager.getConnection(getUrl()); + String fullTableName = SchemaUtil.getTableName(SchemaUtil.normalizeIdentifier(""),SchemaUtil.normalizeIdentifier("dataTable")); + String fullIndexName = SchemaUtil.getTableName(SchemaUtil.normalizeIdentifier(""),SchemaUtil.normalizeIdentifier("idx")); + String dataColumns = "R_KEY VARCHAR, C1 VARCHAR"; + String indexColumns = "C1" ; + String pk = "R_KEY"; + + try { + conn.setAutoCommit(false); + String str1 = "CREATE TABLE " + fullTableName + "(" + dataColumns + " CONSTRAINT pk PRIMARY KEY (" + pk + ")) COLUMN_ENCODED_BYTES=0 "; + conn.createStatement().execute(str1); + + String str2 = "CREATE INDEX idx ON " + fullTableName + "(" + indexColumns + ") "; + conn.createStatement().execute(str2); + conn.commit(); + + Connection conn2 = DriverManager.getConnection(getUrl()); + String upsertStr = "UPSERT INTO " + fullTableName + " VALUES('k1','v1')"; + conn.createStatement().execute(upsertStr); + + //String delStr = "Delete FROM " + fullTableName + " WHERE R_KEY='k1'"; + //conn.createStatement().execute(delStr); + + conn.commit(); + + PhoenixConnection pconn = conn.unwrap(PhoenixConnection.class); + PTable table = pconn.getTable(new PTableKey(pconn.getTenantId(), fullTableName)); + PTable index = pconn.getTable(new PTableKey(pconn.getTenantId(), fullIndexName)); + + Iterator<Pair<byte[],List<Mutation>>> itr = pconn.getMutationState().toMutations(); + Pair<byte[],List<Mutation>> pair = itr.next(); + Put dataPut = (Put)pair.getSecond().get(0); + Delete dataDel = null; + + ImmutableBytesWritable ptr = new ImmutableBytesWritable(); + table.getIndexMaintainers(ptr, pconn); + List<IndexMaintainer> c1 = IndexMaintainer.deserialize(ptr, GenericKeyValueBuilder.INSTANCE, true); + assertEquals(1,c1.size()); + IndexMaintainer im1 = c1.get(0); + + List<Mutation> actualIndexMutations = IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(im1, + dataPut, + dataDel); + List<Mutation> expectedIndexMutations = IndexTestUtil.generateIndexData(index, table, dataPut, ptr, GenericKeyValueBuilder.INSTANCE); + + } + catch(Exception ex){ + LOGGER.error("Failed to run TestOneColumnRowPut. ex={}", ex); + } + finally { + try { + conn.createStatement().execute("DROP TABLE " + fullTableName); + } finally { + conn.close(); + } + } + } + + void addCellToPutMutation(Put put, byte[] family, byte[] column, long ts, byte[] value) throws Exception{ + byte[] rowKey = put.getRow(); + Cell cell = new KeyValue(rowKey, family, column, ts, KeyValue.Type.Put, value); + put.add(cell); + } + + void addCellToDelMutation(Delete del, byte[] family, byte[] column, long ts, KeyValue.Type type) throws Exception{ + byte[] rowKey = del.getRow(); + Cell cell = new KeyValue(rowKey, family, column, ts, type); + del.addDeleteMarker(cell); + } + + void addEmptyColumnToDataPutMutation(Put put, PTable ptable, long ts) throws Exception{ + PName pdefaultFamilyName = ptable.getDefaultFamilyName(); + addCellToPutMutation(put, + pdefaultFamilyName == null ? QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES : pdefaultFamilyName.getBytes(), Review comment: You can use SchemaUtil.getEmptyColumnFamily(table) here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
