kadirozde commented on a change in pull request #733: PHOENIX-5732: Implement
starttime, endtime in IndexTool for rebuild a…
URL: https://github.com/apache/phoenix/pull/733#discussion_r392403340
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java
##########
@@ -85,14 +89,17 @@ protected QueryPlan getQueryPlan(final JobContext
context, final Configuration
Long scn = (currentScnValue != null) ?
Long.valueOf(currentScnValue) : EnvironmentEdgeManager.currentTimeMillis();
configuration.set(PhoenixConfigurationUtil.CURRENT_SCN_VALUE,
Long.toString(scn));
+
Review comment:
We should also change the line 89 above and use the current time - 60
seconds instead of using the current time for setting scn (as we do in
IndexScrutiny). Then we need to sleep 60 second in the index tool before
starting the MR job. If you prefer to do it in a different jira, that is also
fine with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
