kadirozde commented on issue #737: PHOENIX-5773 Index tool output tables should support multiple simulta… URL: https://github.com/apache/phoenix/pull/737#issuecomment-602838272 > > @kadirozde - I offered (and am still offering) to split out the code into a separate class and write read / field parsing logic in a separate JIRA, but I believe @swaroopak 's request for a test to cover the write logic you've changed is still needed for this JIRA. > > @gjacoby126, the change is covered by many existing tests already. You cannot get verification counters correct if the key is not constructed properly. As I said before, this JIRA does not offer anything for parsing or extracting subfields within a row key. > > @kadirozde - I offered (and am still offering) to split out the code into a separate class and write read / field parsing logic in a separate JIRA, but I believe @swaroopak 's request for a test to cover the write logic you've changed is still needed for this JIRA. > > @gjacoby126, the change is covered by many existing tests already. You cannot get verification counters correct if the key is not constructed properly. As I said before, this JIRA does not offer anything for parsing or extracting subfields within a row key. Okay. I have added testing for row keys.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
