stoty commented on a change in pull request #744: PHOENIX-5780 Add mvn 
dependency:analyze to build process
URL: https://github.com/apache/phoenix/pull/744#discussion_r398136615
 
 

 ##########
 File path: phoenix-pherf/pom.xml
 ##########
 @@ -15,463 +15,546 @@
   See the License for the specific language governing permissions and
   limitations under the License.
 -->
-<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-       xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
-       <modelVersion>4.0.0</modelVersion>
-       <parent>
-               <groupId>org.apache.phoenix</groupId>
-               <artifactId>phoenix</artifactId>
-               <version>5.1.0-SNAPSHOT</version>
-       </parent>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.phoenix</groupId>
+    <artifactId>phoenix</artifactId>
+    <version>5.1.0-SNAPSHOT</version>
+  </parent>
 
-       <artifactId>phoenix-pherf</artifactId>
-       <packaging>jar</packaging>
-       <name>Phoenix - Pherf</name>
+  <artifactId>phoenix-pherf</artifactId>
+  <packaging>jar</packaging>
+  <name>Phoenix - Pherf</name>
 
-       <properties>
-               <top.dir>${project.basedir}/..</top.dir>
-               <shaded.package>org.apache.phoenix.shaded</shaded.package>
-       </properties>
+  <properties>
+    <top.dir>${project.basedir}/..</top.dir>
+    <shaded.package>org.apache.phoenix.shaded</shaded.package>
 
-       <dependencies>
-               <dependency>
-                       <groupId>org.apache.phoenix</groupId>
-                       <artifactId>phoenix-core</artifactId>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.phoenix</groupId>
-                       <artifactId>phoenix-core</artifactId>
-                       <type>test-jar</type>
-                       <scope>test</scope>
-               </dependency>
-               <dependency>
-                       <groupId>com.googlecode.java-diff-utils</groupId>
-                       <artifactId>diffutils</artifactId>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.commons</groupId>
-                       <artifactId>commons-lang3</artifactId>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.commons</groupId>
-                       <artifactId>commons-math3</artifactId>
-               </dependency>
+    <!-- Versions for pherf-only dependencies -->
+    <diffutils.version>1.2.1</diffutils.version>
+    <commons-math3.version>3.3</commons-math3.version>
+    <activation.version>1.1</activation.version>
+    <jcabi-jdbc.version>0.15</jcabi-jdbc.version>
+    <system-rules.version>1.8.0</system-rules.version>
+    <stax.version>1.0.1</stax.version>
+    <jaxb.version>2.2.11</jaxb.version>
+  </properties>
+
+  <dependencyManagement>
+    <dependencies>
+      <dependency>
+        <groupId>com.googlecode.java-diff-utils</groupId>
+        <artifactId>diffutils</artifactId>
+        <version>${diffutils.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>org.apache.commons</groupId>
+        <artifactId>commons-math3</artifactId>
+        <version>${commons-math3.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>javax.activation</groupId>
+        <artifactId>activation</artifactId>
+        <version>${activation.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>stax</groupId>
+        <artifactId>stax-api</artifactId>
+        <version>${stax.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>javax.xml.bind</groupId>
+        <artifactId>jaxb-api</artifactId>
+        <version>${jaxb.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>org.glassfish.jaxb</groupId>
+        <artifactId>jaxb-runtime</artifactId>
+        <version>${jaxb.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>com.jcabi</groupId>
+        <artifactId>jcabi-jdbc</artifactId>
 
 Review comment:
   Yes, there are some more of those, but I had to draw the line somewhere.
   My favourite so far is having four places in the code where we process JSON, 
and using three different libraries for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to