stoty commented on a change in pull request #744: PHOENIX-5780 Add mvn 
dependency:analyze to build process
URL: https://github.com/apache/phoenix/pull/744#discussion_r398137415
 
 

 ##########
 File path: phoenix-core/pom.xml
 ##########
 @@ -212,30 +335,16 @@
       <groupId>org.apache.tephra</groupId>
       <artifactId>tephra-core</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.apache.tephra</groupId>
-      <artifactId>tephra-core</artifactId>
-      <type>test-jar</type>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.tephra</groupId>
       <artifactId>tephra-hbase-compat-2.0</artifactId>
     </dependency>
 
-    <!-- Make sure we have all the antlr dependencies -->
+    <!-- Other dependencies -->
     <dependency>
       <groupId>org.antlr</groupId>
       <artifactId>antlr-runtime</artifactId>
     </dependency>
-    <dependency>
-      <groupId>jline</groupId>
-      <artifactId>jline</artifactId>
-    </dependency>
-    <dependency>
-      <groupId>sqlline</groupId>
-      <artifactId>sqlline</artifactId>
 
 Review comment:
   Right, I forgot because the code does not refer to it.
   I feel that it belongs to client. I also updated it to 1.9 now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to