Hadoop QA commented on PHOENIX-5791:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against 4.x-HBase-1.5 branch at commit 
  ATTACHMENT ID: 12997762

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:green}+1 tests included{color}.  The patch appears to include 25 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +diff --git 
+diff --git 
++     * IndexMaintainer.getIndexedColumns() returns the data column references 
for indexed columns. The data columns are
++     * grouped into three classes, pk columns (data table pk columns), the 
indexed columns (the columns for which
++     * we want to have indexing; they form the prefix for the primary key for 
the index table (after salt and tenant id))
++     * and covered columns. The purpose of this method is to find out if all 
the indexed columns are included in the
+     private boolean hasAllIndexedColumns(IndexMaintainer indexMaintainer, 
MultiMutation multiMutation) {
+-                        Bytes.compareTo(CellUtil.cloneQualifier(cell), 
columnReference.getQualifier() ) == 0) {
+-                                           BatchMutateContext context, long 
now, PhoenixIndexMetaData indexMetaData)

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results: 
Release audit warnings: 
Console output: 

This message is automatically generated.

> Eliminate false invalid row detection due to concurrent updates 
> ----------------------------------------------------------------
>                 Key: PHOENIX-5791
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5791
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>         Attachments: PHOENIX-5791.4.x-HBase-1.5.001.patch
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
> IndexTool verification generates an expected list of index mutations from the 
> data table rows and uses this list to check if index table rows are 
> consistent with the data table. To do that it follows the following steps:
>  # The data table rows are scanned with a raw scan. This raw scan is 
> configured to read all versions of rows. 
>  # For each scanned row, the cells that are scanned are grouped into two 
> sets: put and delete. The put set is the set of put cells and the delete set 
> is the set of delete cells.
>  # The put and delete sets for a given row are further grouped based on their 
> timestamps into put and delete mutations such that all the cells in a 
> mutation have the timestamp. 
>  # The put and delete mutations are then sorted within a single list. 
> Mutations in this list are sorted in ascending order of their timestamp. 
> The above process assumes that for each data table update, the index table 
> will be updated with the correct index row key. However, this assumption does 
> not hold in the presence of concurrent updates.
> From the consistent indexing design (PHOENIX-5156) perspective, two or more 
> pending updates from different batches on the same data row are concurrent if 
> and only if for all of these updates the data table row state is read from 
> HBase under the row lock and for none of them the row lock has been acquired 
> the second time for updating the data table. In other words, all of them are 
> in the first update phase concurrently. For concurrent updates, the first two 
> update phases are done but the last update phase is skipped. This means the 
> data table row will be updated by these updates but the corresponding index 
> table rows will be left with the unverified status. Then, the read repair 
> process will repair these unverified index rows during scans.
> Since expected index mutations are derived from the data table row after 
> these concurrent mutations are applied, the expected list would not match 
> with the actual list of index mutations.  

This message was sent by Atlassian Jira

Reply via email to