[
https://issues.apache.org/jira/browse/PHOENIX-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068271#comment-17068271
]
Sandeep Guggilam commented on PHOENIX-5775:
-------------------------------------------
[~ckulkarni] The pherf tests are already run as part of our precommit builds.
Sample here :
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3662/testReport/org.apache.phoenix.pherf/]
I have looked into the issue of PherfTest failing on our local setup but not on
the Phoenix build machine. We load all the resources from tha java class path
and get the .sql files from the resources. When we look at the built classes (
which is our local setup) , we add the /datamodel at the beginning because of
which it cannot find .sql files that are not present in the directory structure
expected. We fixed the issue by allowing few directories to be ignored which
might be needed for testing something else using the Jira PHOENIX-5776
Now coming to the issue of why the same is not failing in build machine, that
is because the code looks for the resource from the JAR when it doesn't find in
the built classes. In the build machine it gets it from the phoenix-core.jar
and hence it could locate it. But the local setup doesn't contain jar in the
class path as it is dependent on another phoenix project.
I think we can never this Jira since it is working as expected and we resolved
the local setup test failure issue using the other issue
> Make PreCommit build run all Phoenix tests
> ------------------------------------------
>
> Key: PHOENIX-5775
> URL: https://issues.apache.org/jira/browse/PHOENIX-5775
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Chinmay Kulkarni
> Priority: Major
> Labels: phoenix-hardening
>
> Currently, it looks like the Hadoop QA PreCommit build only runs tests in
> phoenix-core. This skips running tests in phoenix-pherf and other modules. We
> should ideally run all tests in the project.
> For ex:
> https://builds.apache.org/job/PreCommit-PHOENIX-Build/3546//testReport/ for
> PHOENIX-5607 master branch,
> shows that the build only ran phoenix-core tests, however phoenix-pherf tests
> like PherfTest.java and ResourceTest.java fail and this was not captured.
> These tests may have been failing for a long time (not necessarily related to
> 5607 changes).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
