dbwong commented on a change in pull request #746: PHOENIX-5802: Connection
leaks in UPSERT SELECT/DELETE paths due to MutatingParallelIteratorFactory
iterator not being closed
URL: https://github.com/apache/phoenix/pull/746#discussion_r399591916
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
##########
@@ -175,8 +175,10 @@ private static void setValues(byte[][] values, int[]
pkSlotIndex, int[] columnIn
mutation.put(ptr, new RowMutationState(columnValues, columnValueSize,
statement.getConnection().getStatementExecutionCounter(), rowTsColInfo,
onDupKeyBytes));
}
- public static MutationState upsertSelect(StatementContext childContext,
TableRef tableRef, RowProjector projector,
- ResultIterator iterator, int[] columnIndexes, int[] pkSlotIndexes,
boolean useServerTimestamp, boolean prefixSysColValues) throws SQLException {
+ public static MutationState upsertSelect(StatementContext childContext,
TableRef tableRef,
Review comment:
This class was just formating only correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
