[
https://issues.apache.org/jira/browse/PHOENIX-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069194#comment-17069194
]
Chinmay Kulkarni edited comment on PHOENIX-5806 at 3/28/20, 2:33 AM:
---------------------------------------------------------------------
FYI [~sukumaddineni] [~dbwong] [~smehta] [~larsh] [~apurtell] [~kadir]
was (Author: ckulkarni):
FYI [~sukumaddineni] [~smehta] [~larsh] [~apurtell] [~kadir]
> Add a framework to assert relevant metric values between runs of each test
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5806
> URL: https://issues.apache.org/jira/browse/PHOENIX-5806
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Priority: Major
> Labels: phoenix-hardening
>
> We should ensure that certain metrics are the expected value in between each
> test run. For example, each test should ensure resources (such as
> connections/statements) are closed after their use and can assert that the
> total Phoenix connection count is zero.
> This Jira broadly aims at 2 things:
> # Modifying existing tests so that we do not leak resources in the test
> itself
> # Adding a common framework/interface, etc. which all "relevant" tests can
> inherit behavior to assert specific values for metrics and resource usage
> like query failure counts, open phoenix connection counts, etc. We can
> implement something similar as is aimed in
> [PHOENIX-5296|https://issues.apache.org/jira/browse/PHOENIX-5296]
> The idea is to use this Jira to brainstorm various ideas. This will also help
> uncover resource leaks/incorrect metric updates throughout the code base.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
