[
https://issues.apache.org/jira/browse/PHOENIX-5807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070672#comment-17070672
]
Hadoop QA commented on PHOENIX-5807:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12998162/PHOENIX-5807.4.x.001.patch
against 4.x branch at commit 9dd7d9d8a720c1f98bbe1564f5cfee16b8c5d507.
ATTACHMENT ID: 12998162
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // No need to run the same test twice one for async = true and
the other for async = false
+ populateTable(dataTableName); // with two rows ('a', 'ab', 'abc',
'abcd') and ('b', 'bc', 'bcd', 'bcde')
+ conn.createStatement().execute("upsert into " + dataTableName + "
values ('a', 'abc','abcc', 'abccd')");
+ // The above upsert will create an unverified index row with row
key {'abc', 'a'} and will make the existing
+ // Do major compaction which will remove the empty column cell
from the index row with row key {'ab', 'a'}
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3679//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3679//console
This message is automatically generated.
> Index rows without empty column should be treated as unverified
> ---------------------------------------------------------------
>
> Key: PHOENIX-5807
> URL: https://issues.apache.org/jira/browse/PHOENIX-5807
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-5807.4.x.001.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In the new index design, an index row is composed of cells with the same
> timestamp and the empty column cell holds the verify status of the row.
> However, it is possible that the empty column of an index row can be
> compacted away if the row is made unverified due to a failed data table
> overwrite. This failed overwrite will make the existing verified row index
> row unverified by overwriting the existing row with the empty column cell
> with the unverified status. If this row is not scanned before the next major
> compaction, the empty column cell of the overwritten index row can be removed
> by the compaction since there will be more than one version of it. If this
> row is retrieved via an SCN connection, then the returned row will not
> include the empty column cell. Not having empty column is treated as an
> exception currently. Instead, the row without an empty column should be
> treated as an unverified row and it should be repaired.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
