[ 
https://issues.apache.org/jira/browse/PHOENIX-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071035#comment-17071035
 ] 

Hadoop QA commented on PHOENIX-5793:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12998232/PHOENIX-5793-v4.patch
  against master branch at commit 12982654dbbbbcb3a72c987536b9ea75450e2c05.
  ATTACHMENT ID: 12998232

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to 
fail .

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[302,48]
 cannot find symbol
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[312,9]
 method does not override or implement a method from a supertype
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[452,13]
 cannot find symbol
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[452,36]
 cannot find symbol
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[453,13]
 cannot find symbol
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[453,53]
 cannot find symbol
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[454,18]
 cannot find symbol
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[458,13]
 cannot find symbol
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) 
on project phoenix-core: Compilation failure: Compilation failure: 
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[302,48]
 cannot find symbol
[ERROR]   symbol:   class Callable
[ERROR]   location: class org.apache.phoenix.execute.SortMergeJoinPlan
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[312,9]
 method does not override or implement a method from a supertype
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[452,13]
 cannot find symbol
[ERROR]   symbol:   class ExecutorService
[ERROR]   location: class 
org.apache.phoenix.execute.SortMergeJoinPlan.BasicJoinIterator
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[452,36]
 cannot find symbol
[ERROR]   symbol:   variable Executors
[ERROR]   location: class 
org.apache.phoenix.execute.SortMergeJoinPlan.BasicJoinIterator
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[453,13]
 cannot find symbol
[ERROR]   symbol:   class ExecutorCompletionService
[ERROR]   location: class 
org.apache.phoenix.execute.SortMergeJoinPlan.BasicJoinIterator
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[453,53]
 cannot find symbol
[ERROR]   symbol:   class ExecutorCompletionService
[ERROR]   location: class 
org.apache.phoenix.execute.SortMergeJoinPlan.BasicJoinIterator
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[454,18]
 cannot find symbol
[ERROR]   symbol:   class Future
[ERROR]   location: class 
org.apache.phoenix.execute.SortMergeJoinPlan.BasicJoinIterator
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java:[458,13]
 cannot find symbol
[ERROR]   symbol:   class Future
[ERROR]   location: class 
org.apache.phoenix.execute.SortMergeJoinPlan.BasicJoinIterator
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :phoenix-core
    

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3681//console

This message is automatically generated.

> Support parallel init and fast null return for SortMergeJoinPlan.
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-5793
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5793
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Chen Feng
>            Assignee: Chen Feng
>            Priority: Minor
>         Attachments: PHOENIX-5793-v2.patch, PHOENIX-5793-v3.patch, 
> PHOENIX-5793-v4.patch
>
>
> For a join sql like A join B. The implementation of SortMergeJoinPlan 
> currently inits the two iterators A and B one by one.
> By initializing A and B in parallel, we can improve performance in two 
> aspects.
> 1) By overlapping the time in initializing.
> 2) If one child query is null, the other child query can be canceled since 
> the final result must be null.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to