gjacoby126 commented on a change in pull request #750: PHOENIX-5799 - Inline
Index Verification Output API
URL: https://github.com/apache/phoenix/pull/750#discussion_r401978569
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -154,6 +143,8 @@
private int singleRowRebuildReturnCode;
private Map<byte[], NavigableSet<byte[]>> familyMap;
private byte[][] viewConstants;
+ private IndexVerificationResultRepository verificationResultRepository;
Review comment:
Each repo controls insert/select operations for a particular table: the
result table (PHOENIX_INDEX_TOOL_RESULT) that stores summary information about
the run (counters, etc), and the output table (PHOENIX_INDEX_TOOL) that
contains the row-level information about the failed rows.
Please let me know if you have suggestions on clearer names.
(The word "Repository", btw, is the name of the design pattern being used --
https://martinfowler.com/eaaCatalog/repository.html , from Martin Fowler's
Patterns of Enterprise Architecture and Eric Evans' Domain Driven Design)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
