[ 
https://issues.apache.org/jira/browse/PHOENIX-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073682#comment-17073682
 ] 

Mate Szalay-Beko commented on PHOENIX-5810:
-------------------------------------------

just a few small comments for v1.patch:

{{LOGGER.info("answer1 = " + answer);}}
 here maybe being more informative in the log line would be great, like:
 {{LOGGER.info("Try to locate YARN Resource Manager hostname in the config. " + 
hostname + "=" + answer);}}


and similarly: {{LOGGER.info("answer2 = " + answer);}}
 could be extended like: {{LOGGER.info(address + "=" + answer);}}


small typo: \{{ // In case of yarn HA in NOT enabled}}. ->. \{{ // In case of 
yarn HA is NOT enabled. }}


just a question for line 89: why do you have 
{{!answer.equals(YarnConfiguration.DEFAULT_RM_ADDRESS)}} in the condition? Are 
you sure the DEFAULT_RM_ADDRESS doesn't contain port number postfix? Why is 
YarnConfiguration.DEFAULT_RM_ADDRESS special?

> PhoenixMRJobSubmitter is not working on a cluster with a single yarn RM
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-5810
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5810
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Richard Antal
>            Assignee: Richard Antal
>            Priority: Major
>         Attachments: PHOENIX-5810.master.v1.patch
>
>
> {code:java}
> Exception in thread "main" 
> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = 
> NoNode for /yarn-leader-election{code}
> The error happens when we want to run scheduleIndexBuilds. In 
> getSubmittedYarnApps, getActiveResourceManagerHost uses zookeeper to 
> determine the active Resource Manager.
>  But /yarn-leader-election only exists if yarn is in HA mode.
> I think this function should work well when we have single yarn RM and read 
> its address from the config.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to