[
https://issues.apache.org/jira/browse/PHOENIX-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078310#comment-17078310
]
Istvan Toth commented on PHOENIX-5826:
--------------------------------------
I misread the code. We are actually storing a string into Zookeeper, so this
won't break backwards compatibility, we'll just have to write a compatible
toString/parser method.
So the only change would be the the Java API of the load-balancer service if
someone updates its dependency, which is not really a problem.
> Remove guava from queryserver
> -----------------------------
>
> Key: PHOENIX-5826
> URL: https://issues.apache.org/jira/browse/PHOENIX-5826
> Project: Phoenix
> Issue Type: Improvement
> Components: queryserver
> Affects Versions: queryserver-1.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> The queryserver repo has to work with multiple phoenix branches.
> HBase and Hadoop master has already migrated to guava27/28.
> Queryserver has to work both with the 4.x branch, which will probably have to
> stay on the old guava version, and master, which will have to be upgraded to
> 28.
> The queryserver codebase does not work with Guava 28.
> The simplest way to solve this problem is to remove guava from the
> queryserver modules.
> Most of the guava uses are trivial to replace, but unfortunately changing the
> host information that load-balancer stores in zookeeper is a non backward
> compatible change. The HostAndPort object would have to be replaced by
> something like InetSocketAddress .
> Since we are before the first release of the unbundled queryserver, I think
> that this a great time to get this done with minimal disruption to the users.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
