[
https://issues.apache.org/jira/browse/PHOENIX-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080651#comment-17080651
]
Hadoop QA commented on PHOENIX-5804:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12999562/PHOENIX-5804.4.x.v3.patch
against 4.x branch at commit 39a34b8fae743c63f634ef0366c2de130a621bbe.
ATTACHMENT ID: 12999562
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static Cell getErrorMessageFromIndexToolOutputTable(Connection
conn, String dataTableFullName, String indexTableFullName)
+
serverProps.put(QueryServices.MAX_SERVER_METADATA_CACHE_TIME_TO_LIVE_MS_ATTRIB,
Long.toString(5));
+ + " (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR, CODE
VARCHAR) COLUMN_ENCODED_BYTES=0");
+ "CREATE INDEX %s ON %s (NAME) INCLUDE (CODE)",
indexTableName, dataTableFullName));
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (1, 'Phoenix', 'A')");
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (2, 'Phoenix1', 'B')");
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (3, 'Phoenix2', 'C')");
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (4, 'Phoenix3', 'D')");
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (5, 'Phoenix4', 'E')");
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (6, 'Phoenix5', 'F')");
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.index.VerifySingleIndexRowTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3741//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3741//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3741//console
This message is automatically generated.
> Implement strong verification with -v ONLY option for old design of secondary
> indexes
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-5804
> URL: https://issues.apache.org/jira/browse/PHOENIX-5804
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Attachments: PHOENIX-5804.4.x.v1.patch, PHOENIX-5804.4.x.v3.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, with -v ONLY option we get weak verification i.e. we find out if
> index row is present or not. It does not provide information on if the values
> have mismatch when executed with old design.
> We attempt to provide scrutiny like implementation but way faster. The
> verification will be done only one the latest version of the row.
> This will help us in quantifying the success of new self-consistent secondary
> indexes design.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
