[
https://issues.apache.org/jira/browse/PHOENIX-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081390#comment-17081390
]
Hadoop QA commented on PHOENIX-5629:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12999652/PHOENIX-5629-addendum.4.x-HBase-1.3.001.patch
against 4.x-HBase-1.3 branch at commit
39a34b8fae743c63f634ef0366c2de130a621bbe.
ATTACHMENT ID: 12999652
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ this.optimized = storage ==
ImmutableStorageScheme.SINGLE_CELL_ARRAY_WITH_OFFSETS ? true : false;
+ // verify row timestamp returned by the query matches the
empty column cell timestamp
+ public void
testRowTimestampFunctionAndAdditionalColsWithGreaterThanPredicate() throws
Exception {
+ assertTrue(kv1Value.substring(0,
"KV2_".length()).compareToIgnoreCase("KV1_") == 0);
+ public FunctionExpression create(List<Expression> children,
StatementContext context) throws SQLException {
+ throw new IllegalArgumentException("PhoenixRowTimestampFunction
does not take any parameters");
+ byte[] emptyColumnName = table.getEncodingScheme() ==
PTable.QualifierEncodingScheme.NON_ENCODED_QUALIFIERS ?
+ List<Expression> emptyColumnExpression = Arrays.asList(new
Expression[] {new KeyValueColumnExpression(new PDatum() {
+ return new PhoenixRowTimestampFunction(emptyColumnExpression,
emptyColumnFamilyName, emptyColumnName);
+
nodes.get(0).getNode().getClass().isAssignableFrom(PhoenixRowTimestampParseNode.class));
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.expression.function.BuiltinFunctionConstructorTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3744//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3744//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3744//console
This message is automatically generated.
> Phoenix Function to Return HBase row timestamp
> ----------------------------------------------
>
> Key: PHOENIX-5629
> URL: https://issues.apache.org/jira/browse/PHOENIX-5629
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Jacob Isaac
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5629-addendum.4.x-HBase-1.3.001.patch,
> PHOENIX-5629.4.x-HBase-1.3.v1.patch, PHOENIX-5629.4.x-HBase-1.3.v2.patch,
> PHOENIX-5629.master.v1.patch, PHOENIX-5629.master.v2.patch
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> t's occasionally useful when diagnosing an issue with Phoenix to be able to
> easily look up the HBase timestamp of the HBase Cell returned by a Phoenix
> query.
> For example:
> SELECT ROW_TIMESTAMP(Column1) FROM Table1 WHERE Column1 = 'SomeValue'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
