[ 
https://issues.apache.org/jira/browse/PHOENIX-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085303#comment-17085303
 ] 

Hadoop QA commented on PHOENIX-5808:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13000180/PHOENIX-5808.master.v1.patch
  against master branch at commit 7b4db73b37d8a67fb0238e405abcf4e5f160a103.
  ATTACHMENT ID: 13000180

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SortMergeJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropIndexedColsIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3761//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3761//console

This message is automatically generated.

> Improve shaded artifact naming convetions
> -----------------------------------------
>
>                 Key: PHOENIX-5808
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5808
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.1.0, 4.x
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>         Attachments: PHOENIX-5808.master.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As suggested by [~elserj] in the dev list, there is room for improvment in 
> the naming of the shaded phoenix artifacts:
>  * We are creating useless unshaded client and server artifacts, which should 
> be removed
>  * This would free up the filenames for adding unversioned symlinks to the 
> shaded client and server JARS in the assembly named (where xx is _client_ or 
> _server_, and version is the phoenix version):
>  ** phoenix-xx-version.jar
>  ** phoenix-xx.jar
>  * We should consider removing the legacy phoenix-verson-xx.jar symlinks to 
> the same



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to