kadirozde commented on a change in pull request #765: PHOENIX-5841 add a
counter for mismatching num of columns
URL: https://github.com/apache/phoenix/pull/765#discussion_r410419020
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -537,6 +536,7 @@ private boolean isMatchingMutation(Mutation expected,
Mutation actual, int itera
byte[] dataKey = indexMaintainer.buildDataRowKey(new
ImmutableBytesWritable(expected.getRow()), viewConstants);
String errorMsg = "Missing cell (in iteration " +
iteration + ") " + Bytes.toString(family) + ":" + Bytes.toString(qualifier);
logToIndexToolOutputTable(dataKey, expected.getRow(),
getTimestamp(expected), getTimestamp(actual), errorMsg);
+ verificationPhaseResult.mismatchingNumberOfCellsCount++;
Review comment:
I think there is value in having separate counters for missing and extra
cells. It will give us more info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
