ChinmaySKulkarni commented on a change in pull request #749: PHOENIX-4521:
Allow Pherf scenario to define per query max allowed query execution duration
after which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r410424488
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java
##########
@@ -131,14 +142,16 @@ private void timedQuery() throws Exception {
Long start = EnvironmentEdgeManager.currentTimeMillis();
Review comment:
Based on our offline discussion, let's consolidate the start and end times
for finding query elapsed time. We already define a `start` time here and also
do the same inside `getResults`. Also the final elapsed time that's written to
the csv is not consistent with the one we check against the query timeout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
