[
https://issues.apache.org/jira/browse/PHOENIX-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090174#comment-17090174
]
Hadoop QA commented on PHOENIX-5841:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13000891/PHOENIX-5841.master.003.patch
against master branch at commit dccc260413591a7ab3133f8040b8547b8e993750.
ATTACHMENT ID: 13000891
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ put.addColumn(RESULT_TABLE_COLUMN_FAMILY,
BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT_COZ_EXTRA_CELLS_BYTES,
+ scanMaxTs,
Bytes.toBytes(Long.toString(verificationResult.before.indexHasExtraCellsCount)));
+ put.addColumn(RESULT_TABLE_COLUMN_FAMILY,
BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT_COZ_MISSING_CELLS_BYTES,
+ scanMaxTs,
Bytes.toBytes(Long.toString(verificationResult.before.indexHasMissingCellsCount)));
+ put.addColumn(RESULT_TABLE_COLUMN_FAMILY,
AFTER_REBUILD_INVALID_INDEX_ROW_COUNT_COZ_EXTRA_CELLS_BYTES,
+ scanMaxTs,
Bytes.toBytes(Long.toString(verificationResult.after.indexHasExtraCellsCount)));
+ put.addColumn(RESULT_TABLE_COLUMN_FAMILY,
AFTER_REBUILD_INVALID_INDEX_ROW_COUNT_COZ_MISSING_CELLS_BYTES,
+ scanMaxTs,
Bytes.toBytes(Long.toString(verificationResult.after.indexHasMissingCellsCount)));
+ private boolean isMatchingMutation(Mutation expected, Mutation actual, int
iteration, IndexToolVerificationResult.PhaseResult verificationPhaseResult)
throws IOException {
+ long missingIndexRowCount, long invalidIndexRowCount, long
indexHasExtraCellsCount, long indexHasMissingCellsCount) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewMetadataIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexSaltedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropIndexedColsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3782//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3782//console
This message is automatically generated.
> When data columns get TTLed, we need inline index validation to publish a
> metric for this
> -----------------------------------------------------------------------------------------
>
> Key: PHOENIX-5841
> URL: https://issues.apache.org/jira/browse/PHOENIX-5841
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5841.4.x.001.patch, PHOENIX-5841.4.x.002.patch,
> PHOENIX-5841.4.x.003.patch, PHOENIX-5841.master.001.patch,
> PHOENIX-5841.master.002.patch, PHOENIX-5841.master.003.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> We do index writes as full row writes. This means all columns keep get
> re-written to index and they have a current timestamp.
> However, if there is a column that did not get updated for a long time (like
> Created_By type of columns that don't change) index inline validation marks
> these as "Index has extra columns". We need to publish an extra metric to
> distinguish these cases since they are expected to be not matching rows.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
