[ 
https://issues.apache.org/jira/browse/PHOENIX-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090983#comment-17090983
 ] 

Mingliang Liu commented on PHOENIX-5867:
----------------------------------------

I agree with [[email protected]] We should consider using the Tool support in 
Hadoop.

If we are using {{ToolRunner.run(indexTool, args)}} then it internally supports 
specifying the conf location as well as -Dkey=value. This is supported by 
GenericOptionsParser, whose usage is like following (per it's help message):
{code:title=GenericOptionsParser::printGenericCommandUsage()}
public static void printGenericCommandUsage(PrintStream out) {
        out.println("Generic options supported are:");
        out.println("-conf <configuration file>        specify an application 
configuration file");
        out.println("-D <property=value>               define a value for a 
given property");
        out.println("-fs <file:///|hdfs://namenode:port> specify default 
filesystem URL to use, overrides 'fs.defaultFS' property from configurations.");
        out.println("-jt <local|resourcemanager:port>  specify a 
ResourceManager");
        out.println("-files <file1,...>                specify a 
comma-separated list of files to be copied to the map reduce cluster");
        out.println("-libjars <jar1,...>               specify a 
comma-separated list of jar files to be included in the classpath");
        out.println("-archives <archive1,...>          specify a 
comma-separated list of archives to be unarchived on the compute machines");
        out.println();
        out.println("The general command line syntax is:");
        out.println("command [genericOptions] [commandOptions]");
        out.println();
    }
{code}

> Add support for property overrides in IndexTool
> -----------------------------------------------
>
>                 Key: PHOENIX-5867
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5867
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5867-4.x.001.patch, PHOENIX-5867-4.x.patch, 
> PHOENIX-5867-master.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Add support to accept property overrides in the form of -Dproperty=value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to