jpisaac commented on pull request #759: URL: https://github.com/apache/phoenix/pull/759#issuecomment-620760090
@vmeka2020 Take a look at PhoenixRuntime.getRequestReadMetricInfo() which uses the ReadMetricQueue() to transform/aggregate the metrics on the table basis. You may be able to use that style to populate your MetricsSource for JMX, much like the QueryLogger uses it to write it to the logs. Using the ReadMetricsQueue and MutationMetricQueue will allow us to reuse already instrumented code. It also properly takes care of failures, retries ... Additional info here - https://phoenix.apache.org/metrics.html FYI @dbwong @ChinmaySKulkarni ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
