jpisaac commented on a change in pull request #762:
URL: https://github.com/apache/phoenix/pull/762#discussion_r417711242
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultMultiViewSplitStrategy.java
##########
@@ -26,28 +26,28 @@
public class DefaultMultiViewSplitStrategy implements MultiViewSplitStrategy {
- public List<InputSplit> generateSplits(List<ViewInfoWritable>
viewsWithTTL, Configuration configuration) {
- int numViewsInSplit =
PhoenixConfigurationUtil.getViewTTLDeleteMapperSplitSize(configuration);
- int numberOfMappers = viewsWithTTL.size() / numViewsInSplit;
- if (Math.ceil(viewsWithTTL.size() % numViewsInSplit) > 0) {
+ public List<InputSplit> generateSplits(List<ViewInfoWritable> views,
Configuration configuration) {
+ int numViewsInSplit =
PhoenixConfigurationUtil.getMultiViewSplitSize(configuration);
Review comment:
Can u add check that numViewsInSplit is non-zero.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
