ChinmaySKulkarni commented on a change in pull request #762: URL: https://github.com/apache/phoenix/pull/762#discussion_r419634130
########## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.mapreduce; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.io.NullWritable; +import org.apache.hadoop.mapreduce.Mapper; +import org.apache.phoenix.exception.SQLExceptionCode; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.mapreduce.util.ConnectionUtil; +import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil; +import org.apache.phoenix.mapreduce.util.ViewInfoTracker; +import org.apache.phoenix.mapreduce.util.ViewInfoTracker.ViewTTLJobState; +import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker; +import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker; +import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.sql.SQLException; + +public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> { + private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class); + private MultiViewJobStatusTracker multiViewJobStatusTracker; + + private void initMultiViewJobStatusTracker(Configuration config) { + try { + Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class; + if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) { + LOGGER.info("Using customized tracker class : " + + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ)); + defaultViewDeletionTrackerClass = Class.forName( + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ)); + } else { + LOGGER.info("Using default tracker class "); + } + this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance(); + } catch (Exception e) { + LOGGER.info("exception " + e.getMessage()); + LOGGER.info("stack trace" + e.getStackTrace().toString()); Review comment: Why are we swallowing the exception here? Can it be rethrown? Also, in case we DO want to swallow the exception and just log it, this should be `error` level. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
