[ https://issues.apache.org/jira/browse/PHOENIX-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104950#comment-17104950 ]
Chinmay Kulkarni commented on PHOENIX-5891: ------------------------------------------- There seems to be some issue running Jacoco with JDK 10+ (at least, maybe it fails post JDK 8). The solution seems to be to set JAVA_HOME to 1.7/1.8 in our builds. Besides this, there is an ongoing discussion about JDK versions in our builds [here|https://lists.apache.org/thread.html/r3918abd240d298db127fcec2df29142046efcf18c58ac867c89eb91f%40%3Cdev.phoenix.apache.org%3E]. FYI [~sandeep.guggilam] > Ensure that code coverage does not drop with subsequent commits > --------------------------------------------------------------- > > Key: PHOENIX-5891 > URL: https://issues.apache.org/jira/browse/PHOENIX-5891 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.0.0, 4.15.0, 4.14.3 > Reporter: Chinmay Kulkarni > Assignee: Chinmay Kulkarni > Priority: Major > Labels: quality-improvement > Fix For: 5.1.0, 4.16.0 > > > With [PHOENIX-5842|https://issues.apache.org/jira/browse/PHOENIX-5842], we > added Jacoco code coverage to Hadoop QA precommit runs. We should add a check > to test-patch.sh to ensure that the code coverage numbers do not drop when > applying a new patch. > This can also check that overall code coverage is above a fixed threshold as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005)