gjacoby126 commented on a change in pull request #779:
URL: https://github.com/apache/phoenix/pull/779#discussion_r425472240
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -159,6 +161,16 @@ public IndexRebuildRegionScanner(final RegionScanner
innerScanner, final Region
}
}
+ private boolean shouldRebuildOrVerify() throws IOException {
+ if(verifyType == IndexTool.IndexVerifyType.ONLY) {
+ return true;
+ }
+ byte [] rowKey =
generateResultTableRowKey(scan.getTimeRange().getMax(),
Review comment:
rather than importing the generateResultTableRowKey here, might be
cleaner to have a ResultRepository "exists" overload that takes Scan,
indexMaintainer, and region name. That keeps the internal details of the table
from "leaking" back into the region scanner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
