kadirozde commented on a change in pull request #785:
URL: https://github.com/apache/phoenix/pull/785#discussion_r428961658
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -635,6 +672,9 @@ public boolean verifySingleIndexRow(Result indexRow,
IndexToolVerificationResult
Collections.sort(expectedMutationList, MUTATION_TS_DESC_COMPARATOR);
Collections.sort(actualMutationList, MUTATION_TS_DESC_COMPARATOR);
if (verifyType == IndexTool.IndexVerifyType.ONLY) {
+ if (actualMutationList.get(0) instanceof Put) {
Review comment:
Yes, look at the previous line :
Collections.sort(actualMutationList, MUTATION_TS_DESC_COMPARATOR);
Such a comment would be misleading as read repair can happen on any version.
If you query with a SCN connection, then read repair will happen on older
version. We do check here only the latest version as older versions will be
always be unverified before newer versions are inserted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
