[
https://issues.apache.org/jira/browse/PHOENIX-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113646#comment-17113646
]
Geoffrey Jacoby commented on PHOENIX-5909:
------------------------------------------
[~ChinmayKulkarni], [~priyankporwal], [~kadir], [~swaroopa]: What constitutes
an acceptable test here? PHOENIX-4042 (global indexing metrics for Indexer) and
PHOENIX-5358 (metrics for GlobalIndexChecker) don't seem to have included tests
at all, but I know we're trying to improve our code coverage. The client side
metrics have nice tests (e.g PhoenixMetricsIT), but I don't see a lot of
instrumentation to verify region-server-side metrics.
Is a simple unit test of the two MetricsImpl classes sufficient, or does all
the server-side instrumentation need to be built so we can verify as part of IT
tests as well? Or is that a separate JIRA?
> Table and index-level metrics for indexing coprocs
> --------------------------------------------------
>
> Key: PHOENIX-5909
> URL: https://issues.apache.org/jira/browse/PHOENIX-5909
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> For many of the metrics which the IndexRegionObserver and GlobalIndexChecker
> coprocs expose, it would be useful to have them broken down by table or
> index, in addition to the current aggregates by region server. This would
> help us determine if, for example, a flood of read repairs was coming from
> one particular index.
> Thanks [~priyankporwal] for the feature suggestion.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
