infraio commented on a change in pull request #35:
URL: https://github.com/apache/phoenix-queryserver/pull/35#discussion_r434389641
##########
File path: bin/queryserver.py
##########
@@ -121,12 +119,11 @@
# " -XX:+UnlockCommercialFeatures -XX:+FlightRecorder
-XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true" + \
# The command is run through subprocess so environment variables are
automatically inherited
-java_cmd = '%(java)s -cp ' + hbase_config_path + os.pathsep +
hadoop_config_path + os.pathsep + \
+java_cmd = '%(java)s -cp ' + hbase_config_path + os.pathsep + \
Review comment:
But the hadoop_conf is only used to start a hbase cluster? For
queryserver, it only need to know the hbase cluster, such as a hbase client,
which don't need to know the hdfs config? I read queryserver's doc and start
queryserver which only have hbase's config. I miss something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
