[
https://issues.apache.org/jira/browse/PHOENIX-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128812#comment-17128812
]
Hadoop QA commented on PHOENIX-5896:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13005162/PHOENIX-5896.v1.patch
against master branch at commit 28525790a2c0851be201c8432c82044f1a1a614e.
ATTACHMENT ID: 13005162
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 300 javac compiler
warnings (more than the master's current 299 warnings).
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR,
CODE VARCHAR) "+tableDDLOptions);
+ "CREATE INDEX %s ON %s (NAME) INCLUDE (CODE)",
indexTableName, dataTableFullName));
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (1, 'Phoenix', 'A')");
+ conn.createStatement().execute("upsert into " + dataTableFullName
+ " values (2, 'Phoenix1', 'B')");
+ IndexTool it = IndexToolIT.runIndexTool(directApi, useSnapshot,
schemaName, dataTableName, indexTableName,
+ it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName,
dataTableName, indexTableName,
+ it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName,
dataTableName, indexTableName,
+ ResultSet rs = conn.createStatement().executeQuery("SELECT * FROM
" + indexTableFullName);
+
Assert.assertFalse(it.isValidLastVerifyTime(EnvironmentEdgeManager.currentTimeMillis()
- 1000L));
+ s.setRowPrefixFilter(Bytes.toBytes(String.format("%s%s%s", scn,
ROW_KEY_SEPARATOR, indexTable)));
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3947//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3947//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3947//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3947//console
This message is automatically generated.
> Implement incremental rebuild along the failed regions in IndexTool
> -------------------------------------------------------------------
>
> Key: PHOENIX-5896
> URL: https://issues.apache.org/jira/browse/PHOENIX-5896
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Attachments: PHOENIX-5896.4.x.add0.patch, PHOENIX-5896.4.x.v1.patch,
> PHOENIX-5896.4.x.v2.patch, PHOENIX-5896.4.x.v3.patch,
> PHOENIX-5896.4.x.v4.patch, PHOENIX-5896.v1.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> As we run the index tool on indexes to be rebuilt after the upgrade, it
> spends some time in rescanning successful regions from the last rebuild. We
> want to make the index tool a little smarter to not rebuild rows from the
> regions that were found in the PIT_result table from the last rebuild.
> PIT_result logs region info if it was successfully rebuilt in the last run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
