[ 
https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148221#comment-17148221
 ] 

Hadoop QA commented on PHOENIX-5975:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13006684/PHOENIX-5975-4.x.002.patch
  against 4.x branch at commit 0bbe2faddce0b9b550a8efd558536bb03cfb133f.
  ATTACHMENT ID: 13006684

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                            "CREATE INDEX %s ON %s (NAME) INCLUDE (ZIP) 
ASYNC ", indexTableName, dataTableFullName);
+            IndexTool indexTool = IndexToolIT.runIndexTool(conf, directApi, 
useSnapshot, schemaName, dataTableName, indexTableName, null, 0, 
IndexTool.IndexVerifyType.BEFORE, new String[0]);
+            assertEquals(NROWS, 
indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
+            assertEquals(NROWS, 
indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
+            assertEquals(NROWS, 
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+            assertEquals(0, 
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_VALID_INDEX_ROW_COUNT).getValue());
+            assertEquals(0, 
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_EXPIRED_INDEX_ROW_COUNT).getValue());
+            assertEquals(0, 
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
+            assertEquals(NROWS, 
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_MISSING_INDEX_ROW_COUNT).getValue());
+            assertEquals(0, 
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue());

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4004//testReport/
Code Coverage results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4004//artifact/phoenix-core/target/site/jacoco/index.html
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4004//console

This message is automatically generated.

> Index rebuild/verification page size should be configurable from IndexTool
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-5975
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5975
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5975-4.x.001.patch, PHOENIX-5975-4.x.002.patch, 
> PHOENIX-5975-4.x.patch, PHOENIX-5975-master.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to