[ 
https://issues.apache.org/jira/browse/PHOENIX-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155041#comment-17155041
 ] 

Kadir OZDEMIR commented on PHOENIX-5986:
----------------------------------------

[~ckulkarni] checkCurrentResult is not used. 

It is interesting that the child link table records are dropped but the syscat 
table still has some records for these child views. In this test, the base 
table has two levels of child views. We need to have two task runs to delete 
both levels. To remove all the child links we need only one task run. In the 
second run, the leaf child views are removed. Either in the second task run no 
action is taken or somehow the query on the syscat table returns some stale 
cache data. Maybe we can add more logging to both SelfHealingTask and 
DropChildViewsTask to see if the second run does something at all. 

> DropTableWithViewsIT.testDropTableWithChildViews is flapping again
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-5986
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5986
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0
>            Reporter: Chinmay Kulkarni
>            Priority: Major
>              Labels: phoenix-hardening, quality-improvement
>             Fix For: 4.16.0
>
>
> DropTableWithViewsIT.testDropTableWithChildViews is flapping again. I see 
> [PHOENIX-5074|https://issues.apache.org/jira/browse/PHOENIX-5074] fixed this 
> test so that the task is run immediately, but somehow this test is still 
> intermittently failing.
> This has caused recent preCommit failures for PHOENIX-5981 (build 
> [4010|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4010//testReport/])
>  and 
>  PHOENIX-5984 (build 
> [4011|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4011//testReport/]).
> When I run this test locally, it passes sometimes and fails sometimes. This 
> is the relevant stack trace:
> {code:java}
> java.lang.AssertionError
>       at org.junit.Assert.fail(Assert.java:87)
>       at org.junit.Assert.assertTrue(Assert.java:42)
>       at org.junit.Assert.assertFalse(Assert.java:65)
>       at org.junit.Assert.assertFalse(Assert.java:75)
>       at 
> org.apache.phoenix.end2end.DropTableWithViewsIT.testDropTableWithChildViews(DropTableWithViewsIT.java:158)
> {code}
> Failure is observed in [this 
> assertion|https://github.com/apache/phoenix/blob/f5ebf2aaa337d0b4b935f10917cee3d99d621c98/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java#L158].
>  I also see that the test sometimes fails because it expects task status to 
> be COMPLETED, but sees status to be STARTED instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to