[
https://issues.apache.org/jira/browse/PHOENIX-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159655#comment-17159655
]
Hadoop QA commented on PHOENIX-5924:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13007825/PHOENIX-5924-master.patch
against master branch at commit 07f1fea40804a9c65e04e336afbeecab534372e0.
ATTACHMENT ID: 13007825
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ try (Statement statement = conn.createStatement() ; ResultSet rs2
= statement.executeQuery(query) ) {
+ RowKeySchema.RowKeySchemaBuilder builder = new
RowKeySchema.RowKeySchemaBuilder(columns.size());
+ KeyRange keyRange =
KeyRange.getKeyRange(pointKeyRange.getLowerRange(), false, KeyRange.UNBOUND,
true);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4052//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4052//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4052//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4052//console
This message is automatically generated.
> RVC Offset does not handle variable length fields exclusive scan boundary
> correctly
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-5924
> URL: https://issues.apache.org/jira/browse/PHOENIX-5924
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Daniel Wong
> Assignee: Daniel Wong
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5924-4.x.patch, PHOENIX-5924-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The way exclusive boundary was handled by incrementing the key for variable
> length fields is incorrect in the scan boundary.
>
> In the following case we incrementing incorrectly from 0x490049 -> 0x490050
> ('1','1' -> '1','2')
> We should increment from 0x490049 -> 0x49004900 ('1','1' -> '1','1'\x00)
> @Test
> public void testScenario() throws Exception \{
> String TEST_DDL = "CREATE TABLE IF NOT EXISTS TEST_SCHEMA (\n"
> + " ORGANIZATION_ID VARCHAR(15), \n" + " TEST_ID
> VARCHAR(15), \n"
> + " CREATED_DATE DATE, \n" + " LAST_UPDATE DATE\n"
> + " CONSTRAINT TEST_SCHEMA_PK PRIMARY KEY (ORGANIZATION_ID,
> TEST_ID) \n" + ")";
> try (Statement statement = conn.createStatement()) {
> statement.execute(TEST_DDL);
> }
> //setup
> List<String> upserts = new ArrayList<>();
> upserts.add("UPSERT INTO TEST_SCHEMA(ORGANIZATION_ID,TEST_ID) VALUES
> ('1','1')");
> upserts.add("UPSERT INTO TEST_SCHEMA(ORGANIZATION_ID,TEST_ID) VALUES
> ('1','10')");
> upserts.add("UPSERT INTO TEST_SCHEMA(ORGANIZATION_ID,TEST_ID) VALUES
> ('2','2')");
> for(String sql : upserts) \{
> try (Statement statement = conn.createStatement()) {
> statement.execute(sql);
> }
> }
> conn.commit();
> String query1 = "SELECT * FROM TEST_SCHEMA";
> String query2 = "SELECT * FROM TEST_SCHEMA OFFSET
> (ORGANIZATION_ID,TEST_ID) = ('1','1')";
> try (Statement statement = conn.createStatement() ; ResultSet rs1 =
> statement.executeQuery(query1) ) \{
> TestUtil.printResultSet(rs1);
> }
> try (Statement statement = conn.createStatement() ; ResultSet rs2 =
> statement.executeQuery(query2) ) \{
> TestUtil.printResultSet(rs2);
> }
> }
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
